Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slight optimization in codegen #856

Merged

Conversation

jeffcharles
Copy link
Collaborator

Description of the change

Wrap the WasiCtx reinitialization in a check so the context is only initialized when it's set to None on the store. This will only initialize it once as opposed to every time.

Why am I making this change?

This will be slightly faster.

Checklist

  • I've updated the relevant CHANGELOG files if necessary. Changes to javy-cli and javy-plugin do not require updating CHANGELOG files.
  • I've updated the relevant crate versions if necessary. Versioning policy for library crates
  • I've updated documentation including crate documentation if necessary.

@saulecabrera saulecabrera merged commit e736396 into main Dec 5, 2024
4 checks passed
@saulecabrera saulecabrera deleted the jc.slight-optimization-of-generating-wasi-ctx-in-codegen branch December 5, 2024 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants