Remove use of shared mutable static #854
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Changes the
codegen
module to use an immutable staticOnceLock
for aMemoryInputPipe
instead of a mutable staticOnceLock
on theWasiCtx
. This shouldn't have any functional impact on the CLI. Integration test time increased from 51.04 seconds to 51.94 seconds which seems like a minor increase considering the number of tests involved.Why am I making this change?
Using shared mutable statics in Rust is very discouraged. We had to disable a lint rule to allow this use. We also can remove some
unsafe
blocks too.Checklist
javy-cli
andjavy-plugin
do not require updating CHANGELOG files.