Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update swc #717

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Update swc #717

merged 1 commit into from
Aug 14, 2024

Conversation

jeffcharles
Copy link
Collaborator

Description of the change

Updating SWC including a code change to convert the filename enum into an Rc to accommodate the new API. This is the only callsite working with filenames for SWC we only have the one file so converting the anonymous filename into an Rc here should be fine.

Why am I making this change?

#714 tried to update SWC but failed due to the breaking API change.

Checklist

  • I've updated the relevant CHANGELOG files if necessary. Changes to javy-cli and javy-core do not require updating CHANGELOG files.
  • I've updated the relevant crate versions if necessary. Versioning policy for library crates
  • I've updated documentation including crate documentation if necessary.

@saulecabrera saulecabrera merged commit c2135a0 into main Aug 14, 2024
16 checks passed
@saulecabrera saulecabrera deleted the jc.update-swc branch August 14, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants