Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Submodule] Use https over git protocol #683

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

ewalk153
Copy link
Contributor

@ewalk153 ewalk153 commented Jul 2, 2024

Description of the change

https is the preferred protocol for cloning repos. This switches the test262 reference to the https protocol.

Why am I making this change?

Cloning the submodule for test262 was failing for me.

Test instructions:

git submodule sync
git submodule update

Previously, I was hitting this security error:

➜  javy git:(add-crypto-hmac-256) ✗ git submodule update
Cloning into '/Users/a_user_name/src/github.com/bytecodealliance/javy/crates/javy/test262'...
[email protected]: Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
fatal: clone of '[email protected]:tc39/test262.git' into submodule path '/Users/a_user_name/src/github.com/bytecodealliance/javy/crates/javy/test262' failed
Failed to clone 'crates/javy/test262'. Retry scheduled
Cloning into '/Users/a_user_name/src/github.com/bytecodealliance/javy/crates/javy/test262'...
[email protected]: Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
fatal: clone of '[email protected]:tc39/test262.git' into submodule path '/Users/a_user_name/src/github.com/bytecodealliance/javy/crates/javy/test262' failed
Failed to clone 'crates/javy/test262' a second time, aborting

Checklist

  • I've updated the relevant CHANGELOG files if necessary. Changes to javy-cli and javy-core do not require updating CHANGELOG files.
  • I've updated the relevant crate versions if necessary. Versioning policy for library crates
  • I've updated documentation including crate documentation if necessary.

https is the preferred protocol for cloning repos. This switches the
test262 reference to the https protocol.
@saulecabrera saulecabrera merged commit 46991c7 into bytecodealliance:main Jul 2, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants