Fix issues between reference counting and the custom JSON.parse implementation
#673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a minimal failing test case where SIMD JSON parsing and reference couting causes a panic. Analysis: Even though our fork of rquickjs disallows GC, it doesn't prevent reference counting. This, combined with the usage of `JS_DefinePropertyValue` which decrements the reference count of each String value inside a map, introduced the bug showcased in this commit.
This commit is follow-up to the previous commit, in which the relationship between reference counting and String Object value creation is fixed by: - Avoiding the usage of `unsafe` APIs - Ensuring that everytime a string value gets created it gets correctly taken into acount. Using rquickjs' safe APIs ensures that new values get cloned, which means that `JS_DupValue` is called, which correctly increases the reference count.
|
I'm still figuring out the CI failures, maybe it's something with GH actions. Locally everything passes 🤷🏽 |
Err - a missing cfg and clippy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This change contains two commits, each with a clear description of the change.
Checklist
javy-cliandjavy-coredo not require updating CHANGELOG files.