Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Javy.JSON by default #671

Merged

Conversation

saulecabrera
Copy link
Member

Description of the change

Prior to this commit this option was true by default in order to profit of the performance benefits of SIMD JSON. Unfortunately this introduced issues with GC which need to be investigated further. In the meantime we're setting as off by default.

Checklist

  • I've updated the relevant CHANGELOG files if necessary. Changes to javy-cli and javy-core do not require updating CHANGELOG files.
  • I've updated the relevant crate versions if necessary. Versioning policy for library crates
  • I've updated documentation including crate documentation if necessary.

@saulecabrera saulecabrera requested a review from jeffcharles June 18, 2024 14:33
Prior to this commit this option was true by default in order to profit
of the performance benefits of SIMD JSON. Unfortunately this introduced
issues with GC which need to be investigated further. In the meantime
we're setting as off by default.
@saulecabrera saulecabrera force-pushed the disable-javy-json-temporarily branch from 7f06fde to e87db51 Compare June 18, 2024 14:37
@saulecabrera saulecabrera merged commit 6119bca into bytecodealliance:main Jun 18, 2024
14 checks passed
@saulecabrera saulecabrera deleted the disable-javy-json-temporarily branch June 18, 2024 14:59
@saulecabrera saulecabrera mentioned this pull request Jun 18, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants