Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flush stdout unconditionally #668

Merged

Conversation

saulecabrera
Copy link
Member

@saulecabrera saulecabrera commented Jun 12, 2024

Description of the change

This commit ensures that stdout is always correctly flushed after writing to it. This is critical for dynamic use-cases of Javy

Checklist

  • I've updated the relevant CHANGELOG files if necessary. Changes to javy-cli and javy-core do not require updating CHANGELOG files.
  • I've updated the relevant crate versions if necessary. Versioning policy for library crates
  • I've updated documentation including crate documentation if necessary.

This commit ensures that `stdout` is always correctly flushed after
reading from it. This is critical for dynamic use-cases of Javy
@saulecabrera saulecabrera requested a review from jeffcharles June 12, 2024 20:25
@saulecabrera saulecabrera enabled auto-merge (squash) June 12, 2024 20:29
@saulecabrera saulecabrera merged commit 7aa1abe into bytecodealliance:main Jun 12, 2024
14 checks passed
@saulecabrera saulecabrera deleted the flush-stdout-unconditionally branch June 12, 2024 20:36
saulecabrera added a commit to saulecabrera/function-runner that referenced this pull request Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants