Introduce the javy-config crate
#664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit prepares the terrain to bridge the gap in configurability between the CLI and Javy, the crate. The intention behind introducing a new crate is to: * Reduce code duplication and sync the options between the CLI and the core crate. * Make it easy to pass the options into WebAssemlby by using bitflags. This PR doesn't introduce any new functionality. A follow up PR will include new commands in the CLI which will make use of the share configuration.
|
In case the intention is not clear from the commit message/PR, the intention is to pass the config as a single u32 into WebAssembly, hence the usage of |
jeffcharles
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit prepares the terrain to bridge the gap in configurability between the CLI and Javy, the crate.
The intention behind introducing a new crate is to:
This PR doesn't introduce any new functionality. A follow up PR will include new commands in the CLI which will make use of the share configuration.
Checklist
javy-cliandjavy-coredo not require updating CHANGELOG files.