Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add relese versions of deprecated crates #642

Merged

Conversation

saulecabrera
Copy link
Member

Description of the change

Follow up to #641; this commit introduces the final versions for publishing the deprecated crates

Checklist

  • I've updated the relevant CHANGELOG files if necessary. Changes to javy-cli and javy-core do not require updating CHANGELOG files.
  • I've updated the relevant crate versions if necessary. Versioning policy for library crates
  • I've updated documentation including crate documentation if necessary.

Follow up to bytecodealliance#641; this commit introduces the final versions for publishing the deprecated crates
@saulecabrera saulecabrera requested a review from jeffcharles May 7, 2024 17:37
Copy link
Collaborator

@jeffcharles jeffcharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to have the dates of the releases so we're in conformance with point 6 in https://keepachangelog.com/en/1.1.0/#how. But the changes are good!

crates/quickjs-wasm-rs/CHANGELOG.md Outdated Show resolved Hide resolved
crates/quickjs-wasm-sys/CHANGELOG.md Outdated Show resolved Hide resolved
@saulecabrera saulecabrera enabled auto-merge (squash) May 7, 2024 18:46
@saulecabrera saulecabrera merged commit 499eac7 into bytecodealliance:main May 7, 2024
14 checks passed
@saulecabrera saulecabrera deleted the release-deprecated-crates branch May 7, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants