Skip serializing object entries w/ undefined value #639
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Improve Javy's Value serializer compatibility with
JSON.stringify
:Why am I making this change?
Encoding a QuickJS value to JSON using the transcoder offers a nice performance gain over QuickJS's
JSON.stringify
, but differs in behaviour. This PR should partially close the gap.Without this change, transcoding the above
{foo: undefined}
to a JSON string would result in{"foo":null}
.This PR fixes that by skipping skipping the deserialization of entries with
undefined
. This is a lossy conversion given serde data model doesn't know aboutundefined
, and both the serdeUnit
andNone
data types are serialized asnull
in JSON.Similar logic is applied to Array values, but in that case the values are nullified instead of skipped.
Checklist
javy-cli
andjavy-core
do not require updating CHANGELOG files.[ ] I've updated the relevant crate versions if necessary. Versioning policy for library crates[ ] I've updated documentation including crate documentation if necessary.