Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify TLS in quickjs-wasm-sys WASI SDK download #544

Merged
merged 3 commits into from
Oct 30, 2023

Conversation

jeffcharles
Copy link
Collaborator

Description of the change

Simplify TLS in quickjs-wasm-sys build script by using hyper-tls. Also stop pinning dependencies since Dependabot will update them anyway.

I'm opting not to add a CHANGELOG entry since this doesn't affect any users of the crate in any way.

Why am I making this change?

This simplifies keeping dependencies up to date by reducing the number of top-level dependencies we need to use and reduces the amount we need to interact with the hyper and tokio APIs. Specifically trying to get #520 working was more time consuming than necessary IMO.

Checklist

  • I've updated the relevant CHANGELOG files if necessary. Changes to javy-cli and javy-core do not require updating CHANGELOG files.
  • I've updated the relevant crate versions if necessary. Versioning policy for library crates
  • I've updated documentation including crate documentation if necessary.

@jeffcharles jeffcharles merged commit fa18258 into main Oct 30, 2023
14 checks passed
@jeffcharles jeffcharles deleted the jc.quickjs-wasm-sys-download branch October 30, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants