Use custom traits instead of libstd's MetadataExt and PermissionsExt.
#343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xt`. Define our own copy of `MetadataExt` and `PermissionsExt` and change the code to use them instead of `std::os::*::fs::MetadataExt` and `std::os::*::fs::PermissionsExt'. In general, we should be moving away from using std's `Ext` traits like this, as they weren't meant to be used in this way. Fixes #342.
sunfishcode
added
the
semver bump
cgwalters
approved these changes
Jan 3, 2024
| fn blksize(&self) -> u64; | ||
| /// Returns the number of blocks allocated to the file, in 512-byte units. | ||
| fn blocks(&self) -> u64; | ||
| #[cfg(target_os = "vxworks")] |
There was a problem hiding this comment.
It seems easy for us to somehow miss future extensions to these traits in std, especially slightly more obscure OSes. This seems to be the main downside of this. But eh, in the end if there's some obscure new API and we don't notice, it can just be added.
There was a problem hiding this comment.
Yeah. All of cap-std already faces this challenge; it's just the nature of what cap-std being what it is.
Remove more uses of the std::os traits, and update the build.rs scripts to fix Rust feature detection.
cgwalters
added a commit
to cgwalters/cap-std-ext
that referenced
this pull request
Jan 18, 2024
Adapt to the changes in that crate, xref bytecodealliance/cap-std#343
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define our own copy of
MetadataExtandPermissionsExtand change the code to use them instead ofstd::os::*::fs::MetadataExtand `std::os::*::fs::PermissionsExt'.In general, we should be moving away from using std's
Exttraits like this, as they weren't meant to be used in this way.Fixes #342.