Fix panics when query file metadata, if timestamps predate the epoch #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's possible for a file to have a timestamp that predates the Epoch. But Rust's std::time::Duration object cannot be negative. So cap-primitives must carefully handle any negative timestamps it gets. Fixes bytecodealliance#328
asomers
force-pushed
the
negative-time
branch
from
a0ea825 to
f7e7d6e
Compare
|
I didn't know timestamps before the epoch were valid. Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible for a file to have a timestamp that predates the Epoch. But Rust's std::time::Duration object cannot be negative. So cap-primitives must carefully handle any negative timestamps it gets.
Fixes #328