Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timezone. #327

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Add timezone. #327

merged 2 commits into from
Nov 1, 2023

Conversation

cdmurph32
Copy link
Contributor

@cdmurph32 cdmurph32 commented Aug 24, 2023

This code only fetches the name of the timezone. The determination of utc offset is left to the runtime.

Issue:
bytecodealliance/wasmtime#4274

WASI Clocks proposal:
WebAssembly/wasi-clocks#48

Relate wasmtime PR:
bytecodealliance/wasmtime#6899

@sunfishcode
Copy link
Member

I apologize for the slow response here!

The cap-std crate is intended to focus on features which are provided by Rust's std. What would you think about moving this code to the cap-time-ext crate, which also lives in this repository? We could also move the implementation from cap-primitives into cap-time-ext, so that users that don't need it wouldn't need the iana-time-zone dependency.

@cdmurph32
Copy link
Contributor Author

No apology necessary. I just figured out how to get it working end-to-end with wasmtime this morning. I didn't even know about the component adapter.

The cap-std crate is intended to focus on features which are provided by
Rust's `std`.
@sunfishcode
Copy link
Member

Thanks!

@sunfishcode sunfishcode merged commit 3663202 into bytecodealliance:main Nov 1, 2023
17 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants