Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: on AsyncReadWrite enforce Sync #901

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: on AsyncReadWrite enforce Sync #901

wants to merge 4 commits into from

Conversation

de-sh
Copy link
Contributor

@de-sh de-sh commented Aug 8, 2024 •
edited
Loading

Fix #900

Type of change

Checklist:

  • Formatted with cargo fmt
  • Make an entry to CHANGELOG.md if it's relevant to the users of the library. If it's not relevant mention why.

@de-sh de-sh marked this pull request as ready for review August 8, 2024 22:21
@coveralls
Copy link

coveralls commented Aug 8, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10313583717

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 36.103%
Totals Coverage Status
Change from base Build 10174958032: 0.0%
Covered Lines: 5970
Relevant Lines: 16536
💛 - Coveralls

hw0lff
hw0lff approved these changes Sep 2, 2024
View reviewed changes
Copy link

@hw0lff hw0lff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I encountered the underlying problem, tested this PR in production and it has been running continuously for 5 days like a charm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hw0lff hw0lff hw0lff approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rumqttc: impl Sync for framed::N?
3 participants
@de-sh @coveralls @hw0lff