Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated prombenchy to support multiple benchmarks on one cluster; adjusted avalanche, removed some experiments for now. #12

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

bwplotka
Copy link
Owner

@bwplotka bwplotka commented Oct 2, 2024

Good to go!

@bwplotka bwplotka requested a review from ridwanmsharif October 2, 2024 08:43
@bwplotka bwplotka force-pushed the flexibility branch 4 times, most recently from 79355f5 to 2a4f9b7 Compare October 2, 2024 09:39
@bwplotka bwplotka marked this pull request as ready for review October 2, 2024 10:48
…usted avalanche, removed some experiments for now.

Signed-off-by: bwplotka <[email protected]>
Copy link
Collaborator

@ridwanmsharif ridwanmsharif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only reviewed the tools/mtypes so far. Overall looks good but left a couple questions about the math. Will review the rest tommorrow

tools/mtypes/main.go Outdated Show resolved Hide resolved
tools/mtypes/main.go Show resolved Hide resolved
Copy link
Collaborator

@ridwanmsharif ridwanmsharif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much simpler than before! I wonder if we could still have atleast one scenario where we kept the operator though - unless there is already a different place for us to catch if the operator adds some regressions? (say it adds a relabelling that causes poor performance)

.github/workflows/golangci-lint.yml Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
manifests/scenarios/gmp-otel/1_collector.yaml Show resolved Hide resolved
manifests/scenarios/gmp/1_collector.yaml Show resolved Hide resolved
tools/mtypes/main.go Outdated Show resolved Hide resolved
manifests/gmp-operator/1_setup.yaml Show resolved Hide resolved
@bwplotka bwplotka force-pushed the flexibility branch 7 times, most recently from 4cc0d89 to b3ba173 Compare October 7, 2024 12:12
Signed-off-by: bwplotka <[email protected]>
@bwplotka bwplotka merged commit 6223913 into main Oct 7, 2024
2 checks passed
bwplotka added a commit to prometheus-community/avalanche that referenced this pull request Oct 8, 2024
…ibutions.

Initially added in bwplotka/prombenchy#12, but it might belong here more.

Signed-off-by: bwplotka <[email protected]>
bwplotka added a commit to prometheus-community/avalanche that referenced this pull request Oct 8, 2024
…ibutions.

Initially added in bwplotka/prombenchy#12, but it might belong here more.

Signed-off-by: bwplotka <[email protected]>
bwplotka added a commit to prometheus-community/avalanche that referenced this pull request Oct 8, 2024
…ibutions.

Initially added in bwplotka/prombenchy#12, but it might belong here more.

Signed-off-by: bwplotka <[email protected]>
bwplotka added a commit to prometheus-community/avalanche that referenced this pull request Oct 8, 2024
…ibutions.

Initially added in bwplotka/prombenchy#12, but it might belong here more.

Signed-off-by: bwplotka <[email protected]>
bwplotka added a commit to prometheus-community/avalanche that referenced this pull request Oct 8, 2024
…ibutions.

Initially added in bwplotka/prombenchy#12, but it might belong here more.

Signed-off-by: bwplotka <[email protected]>
bwplotka added a commit to prometheus-community/avalanche that referenced this pull request Oct 9, 2024
…ibutions. (#97)

Initially added in bwplotka/prombenchy#12, but it might belong here more.

Signed-off-by: bwplotka <[email protected]>
prateeknayak pushed a commit to prateeknayak/avalanche that referenced this pull request Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants