Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scenarios: Add benchmark that uses OTel to scrape all prometheus metrics #11

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

ridwanmsharif
Copy link
Collaborator

@ridwanmsharif ridwanmsharif commented Aug 29, 2024

This change does the following:

  • Update the load generator manifests so it doesn't define what collector should be used (PodMonitoring configs defined in the scenarios directly)
  • Add OTel manifests that run in its own namespace
  • Add OTel config as a config map directly and run it as a daemonset

TODO:

  • Lose the dependency on the GMP operator when the OTel benchmark is run

This change does the following:
- Update the load generator manifests so it doesn't define how to
  collect (PodMonitoring configs defined in the scenarios directly)
- Add OTel manifests that run in its own namespace
- Add OTel config as a config map directly and run it as a daemonset

TODO:
- Get this working :( Still seeing no avalance metrics, even though the
  self metrics are being ingested into GMP
- Lose the dependency on the GMP operator when the OTel benchmark is run
@ridwanmsharif ridwanmsharif marked this pull request as ready for review August 29, 2024 23:56
@ridwanmsharif ridwanmsharif requested a review from bwplotka August 29, 2024 23:59
@ridwanmsharif ridwanmsharif force-pushed the ridwanmsharif/otel-bench branch from a68a53f to bfc4b7f Compare August 30, 2024 00:00
@ridwanmsharif ridwanmsharif force-pushed the ridwanmsharif/otel-bench branch from bfc4b7f to ff96f9a Compare August 30, 2024 00:01
Copy link
Owner

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks!

@bwplotka bwplotka merged commit 5ea77d1 into main Aug 30, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants