Set up service account with appropriate permissions for new benchmarks #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change does the following: - Create the gmp-prombecnh service account during the setup because the core manifests expect them - Grant the service account approriate permissions for the `core` and `gmp-system` namespaces, and connect it to the appropriate k8s service accounts - Have the `gmp-system` namepsace service accounts impersonate the `gmp-prombench` service account - Sort the files in the `kubectlExpandApply` to make sure the resulting combined yaml is valid (previously was invalid sometimes because some files didn't have the `---` delimiter at the start and end) - Use the gke.gcr.io/prometheus-engine/prometheus:v2.45.3-gmp.7-gke.0 image instead
bwplotka
approved these changes
Aug 29, 2024
| @@ -41,6 +41,8 @@ kind: ServiceAccount | |||
| metadata: | |||
| name: operator | |||
| namespace: gmp-system | |||
| annotations: | |||
There was a problem hiding this comment.
Technically I don't think operator requires SVC, does it? 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change does the following:
coreandgmp-systemnamespaces, and connect it to the appropriate k8s service accountsgmp-systemnamepsace service accounts impersonate thegmp-prombenchservice accountkubectlExpandApplyto make sure the resulting combined yaml is valid (previously was invalid sometimes because some files didn't have the---delimiter at the start and end)