cargo clippy

composable-architecture/src/dependencies/values.rs

@@ -25,7 +25,7 @@ impl<T> Default for Dependency<T> {
 /// - The methods of `Dependency` are very similar to those of [`std::option::Option`], as
 ///   dependencies are *optionally* present.
 /// - However, a `Dependency` on a type with a [`DependencyDefault`] also implements the
-///   [`AsRef`], [`Deref`] and [`Borrow`] traits. Event if a value has not been explicitly
+///   [`AsRef`], [`Deref`] and [`Borrow`] traits. Even if a value has not been explicitly
 ///   registered for it, the `Dependency` will still be able to [`as_ref`], [`deref`] and
 ///   [`borrow`] this default value.
 ///

composable-views/src/gesture/mod.rs

@@ -11,7 +11,6 @@ mod tap;
 
 pub use tap::{TapGesture, Target};
 
-
 #[non_exhaustive] // must use `State::default()`
 #[derive(Copy, Clone, Default, Eq, PartialEq)]
 pub struct Values {

composable-views/src/gesture/tap.rs

@@ -69,4 +69,4 @@ impl<V: View> View for Target<V> {
     fn draw(&self, bounds: Bounds, onto: &mut impl Output) {
         self.view.draw(bounds, onto)
     }
-}
+}

composable-views/src/layout/mod.rs

@@ -190,13 +190,12 @@ impl View for () {
     }
 
     #[inline(always)]
-    fn event(&self, event: Event, offset: Point, bounds: Bounds) {}
+    fn event(&self, _event: Event, _offset: Point, _bounds: Bounds) {}
 
     #[inline(always)]
-    fn draw(&self, bounds: Bounds, onto: &mut impl Output) {}
+    fn draw(&self, _bounds: Bounds, _onto: &mut impl Output) {}
 }
 
-
 impl<T: View, const N: usize> View for Horizontal<[T; N]> {
     #[inline]
     fn size(&self) -> Size {
@@ -245,4 +244,4 @@ impl<V: View, const N: usize> Layout for [V; N] {
     fn across(self) -> impl View {
         Horizontal(self)
     }
-}
+}

composable-views/src/lib.rs

@@ -138,13 +138,7 @@ pub trait View: Sized {
         self
     }
 
-
-    fn on_tap<A, E>(
-        self,
-        id: Id,
-        action: A,
-        send: E,
-    ) -> TapGesture<Self, A, E>
+    fn on_tap<A, E>(self, id: Id, action: A, send: E) -> TapGesture<Self, A, E>
     where
         A: Clone,
         E: Effects<A>,
@@ -157,7 +151,6 @@ pub trait View: Sized {
         }
     }
 
-
     fn on_tap_target<A, E>(
         self,
         id: Id,

composable-views/src/modifiers/padding.rs

@@ -17,7 +17,8 @@ impl<V: View> View for Padding<V> {
 
     #[inline(always)]
     fn event(&self, event: Event, offset: Point, bounds: Bounds) {
-        self.view.event(event, offset, bounds.inner_box(self.offsets))
+        self.view
+            .event(event, offset, bounds.inner_box(self.offsets))
     }
 
     #[inline]

composable-views/src/output/svg.rs

@@ -56,7 +56,7 @@ impl Output {
     }
 }
 
-impl super::Output for Output {
+impl crate::Output for Output {
     fn begin(&mut self, x: f32, y: f32, rgba: [u8; 4], transform: &Transform) {
         if !self.data.is_empty() && (rgba != self.rgba || !transform.approx_eq(&self.transform)) {
             self.end_current_node();

composable-views/src/shapes/mod.rs

@@ -22,7 +22,7 @@ pub trait Path: Sized {
 
 /// [Least-squares approximation of the circle using cubic Bézier curves][site]
 ///
-/// > David Ellsworth found the optimal value of c:  
+/// > David Ellsworth found the optimal value of c:
 /// >
 /// > c ≈ 0.5519703814011128603134107
 ///
@@ -177,6 +177,7 @@ impl<T: Path> View for Shape<T> {
     }
 
     #[inline(always)]
+    #[allow(clippy::bool_comparison)]
     fn needs_layout(&self) -> bool {
         self.size.get().is_finite() == false
     }

composable-views/src/text/font.rs

@@ -12,7 +12,7 @@ pub struct Font<'a> {
     size: f32,
 }
 
-impl<'a> Font<'a> {
+impl Font<'_> {
     /// Full font name that reflects all family and relevant subfamily descriptors.
     #[inline]
     pub fn full_name(&self) -> Option<String> {
@@ -78,15 +78,13 @@ impl<'a> Font<'a> {
     /// Capital height,
     #[inline]
     pub fn capital_height(&self) -> Option<f32> {
-        self.face
-            .capital_height().map(|x| x as f32)
+        self.face.capital_height().map(|x| x as f32)
     }
 
     /// x height.
     #[inline]
     pub fn x_height(&self) -> Option<f32> {
-        self.face
-            .x_height().map(|x| x as f32)
+        self.face.x_height().map(|x| x as f32)
     }
 
     /// Line gap,
@@ -133,14 +131,14 @@ impl<'a> Font<'a> {
 impl<'a> Font<'a> {
     /// Create a `Font` from the raw font data.
     #[inline(always)]
-    pub fn from(data: &'a [u8]) -> Option<FontConfig> {
+    pub fn from(data: &'a [u8]) -> Option<FontConfig<'a>> {
         Self::from_collection(data, 0)
     }
 
     /// Create a `Font` from a font collection.
     /// Returns the font at `index`, if any
     #[inline(never)]
-    pub fn from_collection(data: &'a [u8], index: u32) -> Option<FontConfig> {
+    pub fn from_collection(data: &'a [u8], index: u32) -> Option<FontConfig<'a>> {
         let face = Face::from_slice(data, index)?;
 
         Some(FontConfig {
@@ -205,8 +203,7 @@ impl<'a> FontConfig<'a> {
     ///
     #[inline]
     pub fn variation(mut self, tag: &[u8; 4], value: f32) -> Self {
-        self.variations
-            .push((Tag::from_bytes(tag), value));
+        self.variations.push((Tag::from_bytes(tag), value));
 
         self
     }

composable-views/src/text/mod.rs

@@ -96,7 +96,7 @@ impl View for Text<'_> {
             rgba: [u8; 4],
         }
 
-        impl<'a, F: Output> rustybuzz::ttf_parser::OutlineBuilder for Builder<'a, F> {
+        impl<F: Output> rustybuzz::ttf_parser::OutlineBuilder for Builder<'_, F> {
             fn move_to(&mut self, x: f32, y: f32) {
                 self.output.begin(x, y, self.rgba, &self.transform);
             }