fix: zig 0.13.0-dev.46+3648d7df1 #276
Conversation
|
Thanks. It would be easier to review without all the reformatting. Can you try and remove those? |
|
sure, also tests were passing for me. i'll try debugging to see what caused the workflow to fail |
WriteNaN
force-pushed
the
main
branch
3 times, most recently
from
fa04b6c to
882741f
Compare
|
sorry for so many commits, this commit has most of the changes which is very minor (switching from std.ComptimeStringMap). that should be good now. lmk! 🙂 |
|
No worries I'll squash all that :) |
std.ComptimeStringMap -> std.StaticStringMap(T).initComptime() semver check switch should return a default value update README format to pass linting test
src/FFI.zig
Outdated
| ); | ||
| .{ "void", .{ .def_type = .Void } }, | ||
| .{ "anyopaque", .{ .def_type = .Void } }, | ||
| }); |
There was a problem hiding this comment.
The reformatting is due to the last , being removed. Add them back and the diff will disappear.
default error
formatting
|
that should be good? |
|
Almost: you should not have a |
|
oh oops! haha sorry |
InvalidBatchScriptArg
|
that should be it! :D |
|
The error must also exists on the buzz side. You can add it under here: https://github.com/buzz-language/buzz/blob/main/src/lib/errors.buzz#L3 The following means we're going to push on the stack the error ctx.vm.pushErrorEnum("errors.FileSystemError", @errorName(err))Right now zig errors have their counterpart on the buzz side but I plan on simplifying those a little on the buzz side (#157) |
add error to buzz
sorry I missed that, added now. Yes that is true. but I think the access to know what the error exactly is on buzz is also great. |
|
Huh. I'm not reproducing the CI error on my mac. Seems like the mir building step is doing it on a different cpu from the following steps. |
|
Merging anyway, i'll temporarily disable the macos test if this persists |
Minor change to work with zig v13