sync #6
Merged
sync #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without them we had incomplete types.
This is needed, because dlt_common.c includes `<QtGlobal>` which includes implicitly `<qtypes.h>` which contains ``` static_assert(sizeof(ptrdiff_t) == sizeof(size_t), "Weird ptrdiff_t and size_t definitions"); ... ``` But `static_assert` in C is available only from c11 standard. Though this is working with clang, but not with gcc compiler, so we set the standard explicitly to c11.
Signed-off-by: Viktor Kopp <[email protected]>
- Fix couple of warnings - Minor cleanup of dead code - Const-correctness for a couple of funcs Signed-off-by: Viktor Kopp <[email protected]>
We are looping over messages which satisfy this condition since they were filtered in indexer, see DltFileIndexerThread::processMessage method Signed-off-by: Viktor Kopp <[email protected]>
Signed-off-by: Viktor Kopp <[email protected]>
Use new EcuItem::find method where possible Signed-off-by: Viktor Kopp <[email protected]>
Signed-off-by: Alexander Wenzel <[email protected]>
Signed-off-by: Alexander Wenzel <[email protected]>
Signed-off-by: Alexander Wenzel <[email protected]>
Signed-off-by: Alexander Wenzel <[email protected]>
* Add missing includes Without them we had incomplete types. * Set C standard to c11 This is needed, because dlt_common.c includes `<QtGlobal>` which includes implicitly `<qtypes.h>` which contains ``` static_assert(sizeof(ptrdiff_t) == sizeof(size_t), "Weird ptrdiff_t and size_t definitions"); ... ``` But `static_assert` in C is available only from c11 standard. Though this is working with clang, but not with gcc compiler, so we set the standard explicitly to c11.
Signed-off-by: Viktor Kopp <[email protected]>
Signed-off-by: Alexander Wenzel <[email protected]>
Signed-off-by: Alexander Wenzel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.