Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt JSON schema section #88

Merged
merged 3 commits into from
Sep 25, 2023
Merged

Adapt JSON schema section #88

merged 3 commits into from
Sep 25, 2023

Conversation

Polo2
Copy link
Member

@Polo2 Polo2 commented Sep 11, 2023

Two steps in this PR:

  • Add introduction to this JSON Schema section, how it's used by both OpenAPI and AsyncAPI section
  • Add more details about enum and const support

Preview is accessible here:
https://deploy-preview-88--bump-content-hub.netlify.app/help/specifications-support/json-schema/

@netlify
Copy link

netlify bot commented Sep 11, 2023

Deploy Preview for bump-content-hub ready!

Name Link
🔨 Latest commit 546aae9
🔍 Latest deploy log https://app.netlify.com/sites/bump-content-hub/deploys/6511912159104b0007340767
😎 Deploy Preview https://deploy-preview-88--bump-content-hub.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@paulRbr paulRbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

Could you also add the page entry in the navigation menu (for now the page is not accessible from the main navigation) by adding a 'specifications-support/json-schema entry in the sidebars.js file 🙏

Polo2 and others added 3 commits September 25, 2023 15:49
Adapt `sidebar.js` to make sure JSON schema article is visible
from navigation sidebar.
@Polo2 Polo2 merged commit ade58be into main Sep 25, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants