-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
maintenance: upgrade to TypeScript 5, Oclif 4, node 18+ #587
base: main
Are you sure you want to change the base?
Conversation
77dae75
to
44d05d9
Compare
e9b2a42
to
5bafc68
Compare
5bafc68
to
b2d0081
Compare
feedbacks following live test:
bump preview: all good bump preview: all good bump deploy: all good bump diff : all good bump overlay: all good I'm very impressed by this new version of CLI, well done 👏 |
This is an upgrade of the package description to use a modern version of Typescript and use the latest v4 of oclif. It's basically a whole re-write from a scratch generated oclif package.
b2d0081
to
ca74862
Compare
23801ae
to
7dfffad
Compare
As discussed in sync, there was a bug when selecting multiple times the same file: I've fixed the code to only present files that have not yet been selected (and thus the error should not be possible anymore)
Changed the minimal version in the package.json ✅ |
@Polo2 could you take a second look and if happy approve the PR 🙏? |
7dfffad
to
f773e15
Compare
This is basically a re-write from scratch using a newly generated package from Oclif v4 due to a too big of a jump from Oclif v1 to oclif v4.
I've then copied files from our CLI one by one making sure compilation (and features) work.
There are still some work to be done:(all done 🎉)Notes for the reviewer
It's a big PR, sorry for that, we can do a pair-review if you feel like it 🤗.
Also, there are a few things I had to adapt in the CLI to make this current upgrade:
I couldn't get theit works!open
node package to work (it was included in oclif's fancy-ux in v1 but isn't part of oclif anymore). This lead me to comment (and thus disable the--open
flag features of the CLI)bump preview --live
one) because the mocha test process never ends due to the command “waiting”. I tried with mocking thestdin
(as described here) but I don't think an “exit signal” character exists which I can send tostdin
to stop the running command. This lead me to comment the related test.Closes #448