Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: "Compiled with warnings." message when compiling the code for the first time #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SantiagoJimenezQ
Copy link

This pr solves the following issue: #2

Description:
When compiling the code for the first time, the compiler shows a warning ¨Compiled with warnings.¨.
For local development this is not a problem, but when trying to deploy it to "Vercel", it will not accept a build with warnings, which can cause some friction to new users.

Compiled with warnings.

./src/App.js
  Line 2:10:  'ethers' is defined but never used                                                                                          no-unused-vars
  Line 15:9:  Emojis should be wrapped in <span>, have role="img", and have an accessible description with aria-label or aria-labelledby  jsx-a11y/accessible-emoji

Fixes:

  • The line that imports "ethers" is now commented out.
  • The "waving hand" emoji is now wrapped in a 'span'.
  • Some minor changes due to ESLint automatic formatting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant