Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't create an ephemeral builder if it isn't truly needed #2196

Merged
merged 3 commits into from
Jul 8, 2024

Merge branch 'main' into lazy-ephemeral-builder

376513b
Select commit
Loading
Failed to load commit list.
Merged

Don't create an ephemeral builder if it isn't truly needed #2196

Merge branch 'main' into lazy-ephemeral-builder
376513b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Jul 8, 2024 in 0s

68.75% of diff hit (within 10.00% threshold of 70.17%)

View this Pull Request on Codecov

68.75% of diff hit (within 10.00% threshold of 70.17%)

Annotations

Check warning on line 123 in internal/builder/builder.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/builder/builder.go#L119-L123

Added lines #L119 - L123 were not covered by tests

Check warning on line 449 in internal/builder/builder.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/builder/builder.go#L448-L449

Added lines #L448 - L449 were not covered by tests

Check warning on line 530 in pkg/client/build.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/client/build.go#L530

Added line #L530 was not covered by tests

Check warning on line 1574 in pkg/client/build.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/client/build.go#L1573-L1574

Added lines #L1573 - L1574 were not covered by tests

Check warning on line 1580 in pkg/client/build.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/client/build.go#L1579-L1580

Added lines #L1579 - L1580 were not covered by tests