-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New flatten buildpacks/builder implementation - Part 1 - removing depth #1925
New flatten buildpacks/builder implementation - Part 1 - removing depth #1925
Conversation
Removing --depth flag Signed-off-by: Juan Bustamante <[email protected]>
398c8cd
to
068d130
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1925 +/- ##
==========================================
- Coverage 79.64% 79.51% -0.12%
==========================================
Files 174 174
Lines 13126 13074 -52
==========================================
- Hits 10453 10395 -58
- Misses 2010 2016 +6
Partials 663 663
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Juan Bustamante <[email protected]>
Signed-off-by: Juan Bustamante <[email protected]>
Signed-off-by: Juan Bustamante <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @jjbustamante. I added one question to understand it better. It's nice to see all the complexity going away here. My apologies for being the person to suggest 'depth' in the first place.
@natalieparellano thanks for you feedback! I will take a look |
Signed-off-by: Juan Bustamante <[email protected]>
Signed-off-by: Juan Bustamante <[email protected]>
Signed-off-by: Juan Bustamante <[email protected]>
Summary
This PR removes the
--depth
flag frompack builder create
andpack buildpack package
commands, because it is not being used.Output
Before
pack builder create
andpack buildpack package
commands have the following flag:After
The flag is not available.
Documentation
Related
Resolves #1880