Skip to content

Commit

Permalink
fixing some feedback from review
Browse files Browse the repository at this point in the history
Signed-off-by: Juan Bustamante <[email protected]>
  • Loading branch information
jjbustamante committed May 20, 2024
1 parent f733a3a commit e76cf93
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion pkg/project/project.go
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ func warnIfTomlContainsKeysNotSupportedBySchema(schemaVersion string, tomlMetaDa
for _, unsupportedKey := range unsupportedKeys {
logger.Warnf("- %s\n", unsupportedKey)
}
logger.Warn("The above keys will be ignored. If this is not intentional, maybe try updating your schema version.\n")
logger.Warn("The above keys will be ignored. If this is not intentional, try updating your schema version.\n")
}
}

Expand Down
4 changes: 2 additions & 2 deletions pkg/project/project_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -427,7 +427,7 @@ foo = "bar"

_, err = ReadProjectDescriptor(tmpProjectToml.Name(), logger)
h.AssertNil(t, err)
h.AssertContains(t, readStdout(), "Warning: The following keys declared in project.toml are not supported in schema version 0.1:\nWarning: - project.authors\nWarning: - io.buildpacks.build.env\nWarning: - io.buildpacks.build.env.name\nWarning: - io.buildpacks.build.env.value\nWarning: The above keys will be ignored. If this is not intentional, maybe try updating your schema version.\n")
h.AssertContains(t, readStdout(), "Warning: The following keys declared in project.toml are not supported in schema version 0.1:\nWarning: - project.authors\nWarning: - io.buildpacks.build.env\nWarning: - io.buildpacks.build.env.name\nWarning: - io.buildpacks.build.env.value\nWarning: The above keys will be ignored. If this is not intentional, try updating your schema version.\n")
})

it("should warn when unsupported keys, on tables the project owns, are declared with schema v0.2", func() {
Expand Down Expand Up @@ -467,7 +467,7 @@ buzz = ["a", "b", "c"]
h.AssertNil(t, err)

// Assert we only warn
h.AssertContains(t, readStdout(), "Warning: The following keys declared in project.toml are not supported in schema version 0.2:\nWarning: - _.versions\nWarning: - _.licenses.foo\nWarning: - io.buildpacks.build.foo\nWarning: - io.buildpacks.build.foo.name\nWarning: The above keys will be ignored. If this is not intentional, maybe try updating your schema version.\n")
h.AssertContains(t, readStdout(), "Warning: The following keys declared in project.toml are not supported in schema version 0.2:\nWarning: - _.versions\nWarning: - _.licenses.foo\nWarning: - io.buildpacks.build.foo\nWarning: - io.buildpacks.build.foo.name\nWarning: The above keys will be ignored. If this is not intentional, try updating your schema version.\n")
})
})
}
Expand Down

0 comments on commit e76cf93

Please sign in to comment.