Apply suggestions from code review

Co-authored-by: Natalie Arellano <[email protected]> Signed-off-by: Juan Bustamante <[email protected]>
buildpacks · Nov 15, 2023 · 9c53229 · 9c53229
1 parent 21d309e
commit 9c53229
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/pkg/archive/archive.go b/pkg/archive/archive.go
@@ -225,9 +225,9 @@ func WriteDirToTar(tw TarWriter, srcDir, basePath string, uid, gid int, mode int
 				return err
 			}
 
-			if previousPath, ok := hardLinkFiles[inode]; ok {
+			if processedPath, ok := hardLinkFiles[inode]; ok {
 				header.Typeflag = tar.TypeLink
-				header.Linkname = previousPath
+				header.Linkname = processedPath
 				header.Size = 0
 			} else {
 				hardLinkFiles[inode] = header.Name

diff --git a/pkg/buildpack/buildpack.go b/pkg/buildpack/buildpack.go
@@ -229,8 +229,7 @@ func toDistTar(tw archive.TarWriter, descriptor Descriptor, blob Blob) error {
 		header.Name = path.Join(baseTarDir, header.Name)
 
 		if header.Typeflag == tar.TypeLink {
-			header.Linkname = path.Clean(header.Linkname)
-			header.Linkname = path.Join(baseTarDir, header.Linkname)
+			header.Linkname = path.Join(baseTarDir, path.Clean(header.Linkname))
 		}
 		err = tw.WriteHeader(header)
 		if err != nil {