Migrate tests to MUnit + other improvements #210
Conversation
|
Still one mailo test failing (I'll investigate later) |
| assert(Beer.Lager.isInstanceOf[Product]) | ||
| assert(Beer.Lager.isInstanceOf[Serializable]) | ||
| assert(Beer.Lager.isInstanceOf[Beer]) | ||
| assertEquals(Beer.Lager, Beer.Lager) |
There was a problem hiding this comment.
we lost an assertion here (Beer.Ale)
There was a problem hiding this comment.
it was intentional, when I tried to rewrite the assertion it wouldn't even compile ("fruitless type test") and it's such an obvious test that I preferred to drop it.
| val mail2 = mail1.copy(subject = "2") | ||
|
|
||
| emailPersistanceActor ! SendEmail(mail1) | ||
| expectMsg(Queued) |
There was a problem hiding this comment.
This is failing in the CI, didn't investigate so much but we might try to specify duration like expectMsg(durationo)(). I see the defaultPatience is removed.
There was a problem hiding this comment.
I think that's due to the change to the inmemory module of akka persistence (I've dropped the external library since it's not compatible with akka 2.6 and I'm using the internal one).
I'm aware of this and I'm trying to fix it (I can reproduce locally)
There was a problem hiding this comment.
(patience was a ScalaTest thing, used for the eventually part which I have removed)
There was a problem hiding this comment.
ok, fixed (it was a misconfiguration)
|
lgtm, fuck scalatest |
|
Merging to unblock #211 |
This PR: