Improve warnings checks #75
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@giogonzo No one reported a bug for the current implementation, but this greatly simplifies the warning logic and it enables TS to be useful. |
giogonzo
approved these changes
Feb 13, 2019
| > = React.Children.toArray(this.props.children); | ||
|
|
||
| if (!column && hAlignContent === "center") { | ||
| const atLeastOneChildHasHMarginAuto = some(children, child => { |
There was a problem hiding this comment.
not related, and not sure about our current browser support target here, but this could easily be rewritten using Array.prototype.some and maybe drop some kB from the package?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.