Add text and select input #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
federico-ercoles
force-pushed
the
add_text_and_select_input
branch
2 times, most recently
from
92292a8 to
17a168d
Compare
federico-ercoles
force-pushed
the
add_text_and_select_input
branch
from
d1e21c2 to
fa3ddc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR separates the input components from their field counterparts for
TextandSelect, similarly to what we already had forNumberandCheckbox. Naming for these components was inferred from the existing examples.I've had to refactor the
NumberInputcomponent, in order to align it with the new components, which I think would make the PR breaking.I've done some basic testing in Storybook to confirm that there should be no visual or functional regression for the existing
Fieldcomponents, and also to confirm the functionality of theInputcomponents.