Allow virtualizing rows when groupBy is active #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giogonzo
force-pushed
the
virtualize-grouped
branch
from
a9cfedc to
fd5e500
Compare
giogonzo
commented
Sep 22, 2023
| @@ -573,17 +573,34 @@ export const VirtualizedRows = { | |||
| args: { | |||
| stickyHeaders: true, | |||
| height: { custom: 340 }, | |||
| virtualizeRows: true, | |||
| virtualizeRows: { estimateRowHeight: () => 92 }, | |||
There was a problem hiding this comment.
not related to this PR, but I noticed that the table can glitch while scrolling if the estimated height is less than the true one. Since we are defaulting internally to the single line text cell height but with the example data we have multiple lines and thus higher rows, we have to provide the estimates from outside for the examples to work smoothly
gabro
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #778
This PR adds the ability to render a Table that is both virtualized and uses the
groupByfeature