add option to virtualize Table rows #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giogonzo
force-pushed
the
virtualized-table-rows
branch
from
1607dc4 to
8978ee4
Compare
giogonzo
commented
Sep 21, 2023
Comment on lines
89
to
90
| | { groupBy?: C[number]["accessor"]; virtualizeRows?: never } | ||
| | { groupBy?: never; virtualizeRows?: { estimateRowHeight: (index: number) => number } } |
There was a problem hiding this comment.
mutually exclusive for now as I didn't investigate how to support virtualizing tables with groupBy enabled
| numberOfStickyColumns={stickyLeftColumnsIds.length} | ||
| />, | ||
| ...row.leafRows.map((row, index) => { | ||
| <Box style={{ height: tableHeight(height) }} ref={tableContainerRef} overflow="auto"> |
There was a problem hiding this comment.
Not 100% sure of the possible implications of adding an extra wrapper here
giogonzo
force-pushed
the
virtualized-table-rows
branch
from
8978ee4 to
131315f
Compare
giogonzo
force-pushed
the
virtualized-table-rows
branch
from
131315f to
826e7fa
Compare
giogonzo
force-pushed
the
virtualized-table-rows
branch
from
826e7fa to
4d418b6
Compare
giogonzo
force-pushed
the
virtualized-table-rows
branch
from
4d418b6 to
437c8d4
Compare
giogonzo
force-pushed
the
virtualized-table-rows
branch
from
437c8d4 to
ad34e35
Compare
giogonzo
commented
Sep 21, 2023
| typeof virtualizeRowsConfig === "boolean" ? virtualizeRowsConfig : virtualizeRowsConfig != null; | ||
| const estimateSize = | ||
| typeof virtualizeRowsConfig === "boolean" | ||
| ? () => 52 |
There was a problem hiding this comment.
not sure how to pick a proper default value here. In practice, testing it, it doesn't seem to change much
giogonzo
force-pushed
the
virtualized-table-rows
branch
from
1022f4f to
187049f
Compare
giogonzo
force-pushed
the
virtualized-table-rows
branch
from
187049f to
776670a
Compare
giogonzo
force-pushed
the
virtualized-table-rows
branch
from
776670a to
3dfa14f
Compare
gabro
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for virtualizing the rows in a
Table, using@tanstack/react-virtual. Virtualization is opt-in and for the time being it can't be enabled when grouping is also enabled