Allow grouped table headers #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
84
to
87
| type Props< | ||
| C extends ReadonlyArray<SimpleColumnType<string, {}, any>>, | ||
| D extends ReadonlyArray<GroupedColumnType<string, {}, any>> | ||
| > = { |
There was a problem hiding this comment.
@gabro I think this makes the PR breaking, but I'm not sure. What do you think?
There was a problem hiding this comment.
The types are 99% of the times inferred, so I would ignore it
federico-ercoles
force-pushed
the
allow_grouped_table_headers
branch
from
f1945bf to
e413f9d
Compare
gabro
reviewed
Sep 20, 2023
Comment on lines
84
to
87
| type Props< | ||
| C extends ReadonlyArray<SimpleColumnType<string, {}, any>>, | ||
| D extends ReadonlyArray<GroupedColumnType<string, {}, any>> | ||
| > = { |
There was a problem hiding this comment.
The types are 99% of the times inferred, so I would ignore it
| [columns, headerGroups] | ||
| headerGroups[0].headers | ||
| .filter((h) => h.sticky) | ||
| .flatMap((h) => h.columns || [h]) |
There was a problem hiding this comment.
Suggested change
| .flatMap((h) => h.columns || [h]) | |
| .flatMap((h) => h.columns ?? [h]) |
| }} | ||
| lastLeftSticky={ | ||
| header.columns | ||
| ? header.id === stickyLeftColumnGroupsIds[stickyLeftColumnGroupsIds.length - 1] |
There was a problem hiding this comment.
Suggested change
| ? header.id === stickyLeftColumnGroupsIds[stickyLeftColumnGroupsIds.length - 1] | |
| ? header.id === stickyLeftColumnGroupsIds.at(-1) |
🪄
federico-ercoles
force-pushed
the
allow_grouped_table_headers
branch
from
e413f9d to
1ff9df8
Compare
|
Approved offline |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for grouped headers. The following options for simple headers are available:
sticky: "left", the whole group will be sticky, stickiness on singular columns will be ignored