Implement HomePage and MyTheme page #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabro
requested changes
Sep 25, 2023
| @@ -18,14 +16,14 @@ export function SectionCompleted(props: Props) { | |||
| kind="solid" | |||
| hierarchy="secondary" | |||
| label={t("ColorsSection.returnToMyTheme")} | |||
| onPress={props.goToMyTheme} | |||
| onPress={() => navigate("/theme")} | |||
There was a problem hiding this comment.
ButtonLink instead of Button if we're navigating onPress?
Comment on lines
21
to
26
| <Button | ||
| size="large" | ||
| kind="solid" | ||
| hierarchy="primary" | ||
| label={t("ColorsSection.goToTypography")} | ||
| onPress={props.goToTypography} | ||
| onPress={() => navigate("/theme/typography")} |
gabro
approved these changes
Sep 25, 2023
|
@veej there seems to be an issue with the lockfile. Can you run pnpm install locally and push the updated lockfile? |
|
@gabro it seems the workaround to fix the chromatic flakiness with DateField is not working 😞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2023-08-25.at.10.16.23.mov