Reimplement Datepicker with react-aria #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veej
force-pushed
the
datepicker-react-aria
branch
from
97d11a5 to
47cd43d
Compare
veej
commented
Aug 29, 2023
Comment on lines
103
to
104
| width: config.dayWidth, | ||
| height: config.dayHeight, |
There was a problem hiding this comment.
We're no longer limiting the day size in config to be part of the spacing scale.
veej
commented
Aug 29, 2023
Comment on lines
-26
to
+27
| <Box paddingX={12} width="full"> | ||
| <Columns space={4} alignY="center"> | ||
| <Box paddingX={8} width="full"> | ||
| <Columns space={8} alignY="center"> | ||
| <Column width="content"> | ||
| <IconButton | ||
| label={defaultMessages.DateField.previousMonthLabel} | ||
| size={16} | ||
| size={24} |
There was a problem hiding this comment.
changes already discussed with @Phyele
veej
force-pushed
the
datepicker-react-aria
branch
from
c7f2f44 to
ba50061
Compare
|
@veej take a look at Chromatic: some changes look off to me. |
veej
force-pushed
the
datepicker-react-aria
branch
from
cc59eab to
8a4958b
Compare
veej
force-pushed
the
datepicker-react-aria
branch
from
c4cfcc4 to
83b69d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2023-08-29.at.11.50.55.mov