Skip to content

Commit

Permalink
Merge pull request #877 from buildo/fix-deps-types-circular-constraint
Browse files Browse the repository at this point in the history
Add react-table types as dependency and fix type parameter circular constraint
  • Loading branch information
pedrodim authored Jul 31, 2024
2 parents 4963437 + 144c09e commit c837bfc
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion packages/bento-design-system/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@
"@react-types/shared": "3.19.0",
"@tanstack/react-virtual": "3.0.0-beta.65",
"@tanstack/virtual-core": "3.0.0-beta.65",
"@types/react-table": "7.7.20",
"@vanilla-extract/css": "1.13.0",
"@vanilla-extract/dynamic": "2.0.3",
"@vanilla-extract/recipes": "0.5.3",
Expand Down Expand Up @@ -164,7 +165,6 @@
"@types/react-dom": "18.2.7",
"@types/react-input-mask": "3.0.5",
"@types/react-is": "18.2.1",
"@types/react-table": "7.7.20",
"@types/testing-library__jest-dom": "5.14.9",
"@typescript-eslint/parser": "5.62.0",
"@vanilla-extract/babel-plugin": "1.2.0",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Children as Children_ } from "../util/Children";
import { Children } from "../util/Children";

export type TypographySize = "small" | "medium" | "large";
export type TypographyAlign = "left" | "center" | "right" | "justify";
Expand All @@ -19,10 +19,10 @@ export type TypographyColor =

export type TypographyProps<
Align extends TypographyAlign = TypographyAlign,
Children extends Children_ = Children_,
Elements extends Children = Children,
Color extends TypographyColor = TypographyColor
> = {
children: Children;
children: Elements;
size: TypographySize;
color?: Color;
align?: Align;
Expand Down
4 changes: 2 additions & 2 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit c837bfc

Please sign in to comment.