Merge pull request #768 from buildo/fix-767

buildo · Sep 14, 2023 · 6923a15 · 6923a15
2 parents 40280a1 + a373251
commit 6923a15
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/packages/bento-design-system/src/TimeField/TimeField.tsx b/packages/bento-design-system/src/TimeField/TimeField.tsx
@@ -24,10 +24,8 @@ export function TimeField(props: Props) {
   const { locale } = useLocale();
   const validationState = props.isReadOnly ? undefined : props.issues ? "invalid" : "valid";
 
-  // NOTE(gabro): not sure why we need this cast, but we get a build error if we remove it
-  const value = props.value as TimeValue | undefined;
-
-  const onChange = (value: TimeValue) => {
+  const onChange = (value: TimeValue | null) => {
+    if (value == null) return;
     const time = new Time(value.hour, value.minute, value.second, value.millisecond);
     return props.onChange(time);
   };
@@ -37,15 +35,13 @@ export function TimeField(props: Props) {
     validationState,
     isDisabled: props.disabled,
     locale,
-    value,
     onChange,
   });
   const ref = useRef<HTMLDivElement>(null);
 
   const { labelProps, fieldProps, descriptionProps, errorMessageProps } = useTimeField(
     {
       ...props,
-      value,
       onChange,
     },
     state,