In config=remote, use --remote_download_toplevel #8075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had to do a bunch of work to refactor uses of `remote` and `remote-shared` which relied on the fact that remote-shared specified --remote_download_minimal
tempoz
approved these changes
Dec 18, 2024
|
I think I'm going to wait until after the holidays to merge this. I don't want to break something when people aren't around. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to do a bunch of work to refactor uses of
remoteandremote-sharedwhich relied on the fact that remote-shared specified --remote_download_minimal.Bazel logs a warning if different version of --remote_download_* are specified for the same invocation, so I tried to avoid that.