Fix peer dependencies #7900
Fix peer dependencies #7900
Conversation
enterprise/app/trends/heatmap.tsx
Outdated
| const { width, ref } = useResizeDetector({ | ||
| handleHeight: false, | ||
| refreshMode: "throttle", | ||
| refreshRate: 500, | ||
| }); |
There was a problem hiding this comment.
does this work? I thought React hooks (functions prefixed with use) only worked with functional components, and weren't supported for class components
There was a problem hiding this comment.
Then you're probably right; I couldn't test this locally and so was going to test it in dev when I got a free moment. How do you recommend we resolve this? The library just removed the with version, and I wasn't aware of the differing use in class and functional components until just now.
There was a problem hiding this comment.
Personally I'd ignore the deprecation warning
There was a problem hiding this comment.
(and revert to the old version - unless the issue is that this is setting off some security scanner?)
There was a problem hiding this comment.
i also wouldn't expect this to work. if you can't / don't want to revert versions and figure out the class-componenty way of doing this, you should be able to just set an olap db handle to play around with the ui (since you don't need any actual data to verify that resizing is working)
There was a problem hiding this comment.
I switched the HeatmapComponent to a functional component instead of a class component, and it appears to work based on my limited testing I did on my local machine with no real data.
| @@ -265,11 +265,11 @@ export default class FlakesComponent extends React.Component<Props, State> { | |||
| if (!stats) { | |||
| return "0%"; | |||
| } | |||
| const totalFlakes = (+stats.flakyRuns ?? 0) + (+stats.likelyFlakyRuns ?? 0); | |||
| const totalFlakes = +stats.flakyRuns + +stats.likelyFlakyRuns; | |||
There was a problem hiding this comment.
did something change in our proto libraries to make this not a Long or something? if so, i would imagine there are a lot more places than just this one where this could be removed
There was a problem hiding this comment.
I think it made it so that Longs can't fail to be converted to numbers?
There was a problem hiding this comment.
also I think this is likely a result of upgrading typescript, not proto
enterprise/app/trends/heatmap.tsx
Outdated
| const { width, ref } = useResizeDetector({ | ||
| handleHeight: false, | ||
| refreshMode: "throttle", | ||
| refreshRate: 500, | ||
| }); |
There was a problem hiding this comment.
i also wouldn't expect this to work. if you can't / don't want to revert versions and figure out the class-componenty way of doing this, you should be able to just set an olap db handle to play around with the ui (since you don't need any actual data to verify that resizing is working)
tempoz
force-pushed
the
fix-peer-deps
branch
2 times, most recently
from
eb16e16 to
5686ecd
Compare
This addresses all peer dependency warnings we get from yarn except for the
dagre-d3-reactones, which would require a new release of that library to fix.In doing so, it:
Upgrades our typescript version
Switches to using
useResizeDetectorfrom the deprecatedwithResizeDetectorSwitches to using
Rangeinstead of the removedRangeWithKeyandRangeKeyDictinstead of the removedOnChangePropsRemoves code for handling the
daysfield of aRange, as that field no longer existsRemoves the
undefinedsecond positional parameter fromhandleDefaultConfigClicked, as that function no longer accepts a second positional parameterRemoves fallback values when using unary
+to convert aLongto anumber, as that now always returns anumberChanges our target in
tsconfig.jsonfromes2016toes2018to support the use of named capturing groups intrace_events.tsRemoves the
resolutionsblock from ourpackage.json, as it is no longer necessary