Added ability to retrieve camera cal during log playback #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… still be retrieved for log analysis
jpanikulam
requested changes
May 14, 2019
| @@ -62,7 +62,11 @@ std::optional<int> CameraManager::follow_v4l_path(const std::string& path) const | |||
| const std::string v4l_path = fs::canonical(path, ec).string(); | |||
| const int index = v4l_path.back() - '0'; // note that this will break for >10 cameras | |||
| if (ec) { | |||
| return std::nullopt; | |||
| if (getenv("LOG_PATH")) { // if LOG_PATH is set, we can assume that we're in playback mode and the video index won't be used | |||
There was a problem hiding this comment.
Some thoughts:
- Ideally, all of the code paths would be the same, online and offline, so they can't accidentally diverge
- Most consumers of the calibration don't need to actually interact with the camera, and the camerabq never needs the calibration -- those could be two different access paths
- Apparently you can directly open captures via the
v4lpath, so you may be able to remove the camera number munging
There was a problem hiding this comment.
Got it, I'll take closer look when I'm back in town!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is using the environment variable LOG_PATH which should only be set during playback.
https://github.com/build-week/hover-jet/wiki/Playing-Back-Logs