✨ Stop worker gracefully on sigterm #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phlmn
force-pushed
the
phlmn/worker-graceful-stopping
branch
from
e9afc3e to
2e28b89
Compare
|
Overmind decides to kill the worker in the dev setup after a couple of seconds but I think this is okay |
anuejn
reviewed
Dec 13, 2023
Yes this is intentional
ctrl-c should work as expected and stop the worker immediately since it sends SIGINT |
phlmn
force-pushed
the
phlmn/worker-graceful-stopping
branch
from
869736d to
06b7ef9
Compare
pajowu
approved these changes
Dec 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.