Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add basic video preview #405

Merged
merged 6 commits into from
Dec 10, 2023
Merged

✨ Add basic video preview #405

merged 6 commits into from
Dec 10, 2023

Conversation

phlmn
Copy link
Member

@phlmn phlmn commented Dec 6, 2023 •
edited
Loading

closes #377

@phlmn phlmn requested review from pajowu, rroohhh and anuejn December 6, 2023 11:47
@phlmn phlmn force-pushed the phlmn/basic-video-preview branch from 78303c2 to 8c05d9d Compare December 7, 2023 01:48
@phlmn phlmn force-pushed the phlmn/basic-video-preview branch from 03721aa to a4f9011 Compare December 8, 2023 15:20
@phlmn phlmn enabled auto-merge December 9, 2023 23:31
pajowu
pajowu approved these changes Dec 9, 2023
View reviewed changes
Copy link
Member

@pajowu pajowu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some more improvements in #406 but this is fine as is IMHO

@phlmn phlmn added this pull request to the merge queue Dec 9, 2023
Merged via the queue into main with commit c2ff7f3 Dec 10, 2023
2 checks passed
@phlmn phlmn deleted the phlmn/basic-video-preview branch December 10, 2023 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pajowu pajowu pajowu approved these changes

@rroohhh rroohhh Awaiting requested review from rroohhh

@anuejn anuejn Awaiting requested review from anuejn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Video Support
2 participants
@phlmn @pajowu