Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paragraph recombination fixes #395

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Paragraph recombination fixes #395

merged 2 commits into from
Nov 28, 2023

Conversation

pajowu
Copy link
Member

@pajowu pajowu commented Nov 27, 2023

  • 🐛 Skip para recombination if produced para is > 30s
  • 🐛 Fix DONT_COMBINE_RES not doing anything

@pajowu pajowu requested review from anuejn, phlmn and rroohhh November 27, 2023 23:16
anuejn
anuejn approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@anuejn anuejn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice

worker/tests/test_transcribe.py Outdated Show resolved Hide resolved
@pajowu pajowu force-pushed the pajowu/paragraph_recombination branch from 6182b6a to 21a5ec2 Compare November 28, 2023 14:37
@pajowu pajowu enabled auto-merge November 28, 2023 14:37
@pajowu pajowu added this pull request to the merge queue Nov 28, 2023
Merged via the queue into main with commit e406b9f Nov 28, 2023
2 checks passed
@pajowu pajowu deleted the pajowu/paragraph_recombination branch November 28, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anuejn anuejn anuejn approved these changes

@phlmn phlmn Awaiting requested review from phlmn

@rroohhh rroohhh Awaiting requested review from rroohhh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pajowu @anuejn