🔧 Fix unpacking None value in alignment #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phlmn
force-pushed
the
phlmn/fix-alignment-crash
branch
from
034c7fd to
a9eb416
Compare
phlmn
changed the title
pajowu
approved these changes
Sep 28, 2023
pajowu
reviewed
Sep 28, 2023
Comment on lines
+266
to
+267
| if start_info is None or end_info is None: | ||
| continue |
There was a problem hiding this comment.
Could you please add a comment why/how this can happen?
There was a problem hiding this comment.
This is quite a quick and dirty fix for now. I started refactoring the code, but actually I think we should completely redo the alignment instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #352