Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix document import for documents with >1000 changes #348

Merged
merged 1 commit into from
Oct 7, 2023
Merged

🐛 Fix document import for documents with >1000 changes #348

merged 1 commit into from
Oct 7, 2023

Conversation

pajowu
Copy link
Member

@pajowu pajowu commented Sep 3, 2023

No description provided.

@pajowu pajowu requested review from anuejn, rroohhh and phlmn and removed request for anuejn and rroohhh September 3, 2023 13:49
@pajowu pajowu force-pushed the pajowu/fix_archive_import branch from 0d96ddd to 11a78f8 Compare September 3, 2023 13:49
@pajowu pajowu force-pushed the pajowu/fix_archive_import branch 2 times, most recently from 13d725c to 219f246 Compare September 18, 2023 16:16
@pajowu pajowu force-pushed the pajowu/fix_archive_import branch from 219f246 to 7b24561 Compare September 20, 2023 18:34
@pajowu pajowu enabled auto-merge September 20, 2023 18:34
anuejn
anuejn reviewed Oct 7, 2023
View reviewed changes
Copy link
Member

@anuejn anuejn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it broken with >1000 changes in the first place? Why can't we process the changes on the server. Actually that seems like a somewhat more natural way to do it than sending the changes one by one?

@pajowu
Copy link
Member Author

pajowu commented Oct 7, 2023

Starlette only allows 1000 files “for security reasons” -> once we upload more than 1000, we get an http 422 error

anuejn
anuejn approved these changes Oct 7, 2023
View reviewed changes
Copy link
Member

@anuejn anuejn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, fair :)

@pajowu pajowu added this pull request to the merge queue Oct 7, 2023
Merged via the queue into main with commit c1919f5 Oct 7, 2023
2 checks passed
@pajowu pajowu deleted the pajowu/fix_archive_import branch October 7, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anuejn anuejn anuejn approved these changes

@phlmn phlmn Awaiting requested review from phlmn

@rroohhh rroohhh Awaiting requested review from rroohhh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pajowu @anuejn