Add ResourceService for v1beta1 Plugins #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
mfridman
reviewed
Nov 25, 2024
| // Note that certain DigestTypes may be deprecated over time. | ||
| // | ||
| // If not set, the latest DigestType is used, currently P1. | ||
| DigestType digest_type = 2 [(buf.validate.field).enum.defined_only = true]; |
There was a problem hiding this comment.
I think we got rid of this in the v1 (EDIT: module) API, we should probably keep the v1beta1 plugin definitions closer to the v1 module definitions.
emcfarlane
force-pushed
the
ed/addPluginResourceService
branch
from
c29a01f
to
b4a3775
Compare
mfridman
approved these changes
Nov 25, 2024
nicksnyder
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
ResourceServicefor thebuf.registry.plugin.v1beta1Plugins package. Follows the service implementation in Modules. See #132