Add ability to configure base ModuleRole for Organizations #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest Buf updates on your PR.
|
nicksnyder
commented
Jun 6, 2024
| @@ -72,6 +79,21 @@ enum OrganizationVerificationStatus { | |||
| ORGANIZATION_VERIFICATION_STATUS_OFFICIAL = 3; | |||
| } | |||
|
|
|||
| // An access role to a module. | |||
| enum ModuleRole { | |||
There was a problem hiding this comment.
Should this type belong in buf.registry.module instead of buf.registry.organization?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to update the BSR web app to be able to configure the base role at creation time but the current v1 APIs don't support setting/changing this, so the current web UI is implemented by using v1 RPC to create and organization, and then an alpha API to immediately set the base role. It would be ideal if we could update the v1 API to support setting the base role at creation time.
This PR is to start a discussion about if/how we want to represent roles in the organization API. It is ok if the conclusion is we want to defer thinking about this until we think about roles more holistically.