Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove buf.validate.Violations Protobuf message #96

Open
bufdev opened this issue Sep 26, 2023 · 0 comments
Open

Remove buf.validate.Violations Protobuf message #96

bufdev opened this issue Sep 26, 2023 · 0 comments
Labels
Breaking Change Describes a breaking change to the protovalidate API Feature New feature or request

Comments

@bufdev
Copy link
Member

bufdev commented Sep 26, 2023

We don't have a super-concrete use case for having a buf.validate.Violations message, as opposed to using lists of buf.validate.Violation messages. There's a thought that we may want a repeated message wrapper for RPC error details, but we haven't discovered this just yet, and we want to minimize API surface area as much as possible. We'll look to batch this with other breaking changes pre-v1.0.
@bufdev bufdev mentioned this issue Sep 26, 2023
Open
@rodaine rodaine added Feature New feature or request Breaking Change Describes a breaking change to the protovalidate API labels Oct 16, 2023
igor-tsiglyar pushed a commit to igor-tsiglyar/protovalidate that referenced this issue Apr 16, 2024
@pkwarren
Run go mod tidy (bufbuild#96)
8d040f9
jchadwick-buf added a commit that referenced this issue Oct 14, 2024
@jchadwick-buf
Remove Violations message
169285e 
**This is a breaking change.**

Closes #96.
@jchadwick-buf jchadwick-buf mentioned this issue Oct 14, 2024
Closed
1 task
jchadwick-buf added a commit that referenced this issue Oct 14, 2024
@jchadwick-buf
Remove Violations usage from test harness
ff86d21 
Related to #96.
@jchadwick-buf jchadwick-buf mentioned this issue Oct 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Breaking Change Describes a breaking change to the protovalidate API Feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove Violations messages bufbuild/protovalidate
2 participants
@rodaine @bufdev