Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Violations messages #261

Conversation

jchadwick-buf
Copy link
Member

@jchadwick-buf jchadwick-buf commented Oct 14, 2024

This is a breaking change.

Closes #96.

**This is a breaking change.**

Closes #96.
@jchadwick-buf jchadwick-buf requested a review from rodaine October 14, 2024 16:12
Copy link

github-actions bot commented Oct 14, 2024

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed❌ failed (2)Oct 16, 2024, 2:55 PM

@jchadwick-buf
Copy link
Member Author

Actually hold on: I'm going to split this in two, one to remove the usage from protovalidate-testing and one to remove the message from protovalidate. That way we can do it in two separate releases and avoid needing to hack around module syncing issues.

@jchadwick-buf jchadwick-buf changed the title Remove Violations message Remove Violation and Violations messages Oct 16, 2024
@jchadwick-buf jchadwick-buf changed the base branch from main to jchadwick/remove-violations-from-testing October 16, 2024 14:50
@jchadwick-buf jchadwick-buf changed the title Remove Violation and Violations messages Remove Violations messages Oct 16, 2024
@jchadwick-buf
Copy link
Member Author

Closing this for now as we've determined after extensive discussion that we can't really do this right now, due to existing uses of Violations and Violation outside of protovalidate itself. Will revisit before 1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove buf.validate.Violations Protobuf message
1 participant